John Passaniti
|
| Posted: 06/01/2001, 10:44 AM |
|
I have noticed several odd things about the Perl code generated by
CodeCharge.
1) In the TextTemplate.pm module, I note that replaceBlock replaces
subordinate templates with the name of the template in curly brackets. Such
replacements were evidently meant to allow other delimiters for template
names-- blockVars accepts strings for the starting and ending delimiters.
However, I don't see a way to change these delimiters in CodeCharge.
Hopefully that will be in a future version.
2) Although I like the speed of the CGI code in Common.pm, I'd also like to
see the option of using CGI.pm. After all, if you are going to use standard
modules like DBI, you should also give the option of using CGI.pm, which is
just as common in web-based Perl applications. I'm not suggesting getting
rid of the CGI code that is there now (although breaking it into a separate
module makes sense), but making the use of CGI.pm an option.
3) Also in Common.pm, DelOldTempSession is defined, but never called. I
assume this means people who are generating Perl code are quietly
accumulating temporary session files...
4) Again in Common.pm, ToSQL is wrong. Instead of assuming that all
database drivers use single quotes to delimit strings, it should use the
DBI's quote function, which does this is a portable way.
5) The functions related to session variable could be a lot more efficient
by factoring out the reading and writing to the file. Right now, each call
to GetSessionVar or SetSessionVar causes either a reread or a rewrite of the
underlying session file. This is wasteful.
|
|
|
 |
CodeCharge
|
| Posted: 06/01/2001, 5:54 PM |
|
John,
Thank you for the valuable feedback.
We are always up for improvements and some of the things you mention are
farily easy to modify, so if our developers validate your feedback, we'll
have this done.
Adam S.
CodeCharge Support
"John Passaniti" <nntp@JapanIsShinto.com> wrote in message
news:9f8kak$prh$1@mail.tankhill.com...
> I have noticed several odd things about the Perl code generated by
> CodeCharge.
>
> 1) In the TextTemplate.pm module, I note that replaceBlock replaces
> subordinate templates with the name of the template in curly brackets.
Such
> replacements were evidently meant to allow other delimiters for template
> names-- blockVars accepts strings for the starting and ending delimiters.
> However, I don't see a way to change these delimiters in CodeCharge.
> Hopefully that will be in a future version.
>
> 2) Although I like the speed of the CGI code in Common.pm, I'd also like
to
> see the option of using CGI.pm. After all, if you are going to use
standard
> modules like DBI, you should also give the option of using CGI.pm, which
is
> just as common in web-based Perl applications. I'm not suggesting getting
> rid of the CGI code that is there now (although breaking it into a
separate
> module makes sense), but making the use of CGI.pm an option.
>
> 3) Also in Common.pm, DelOldTempSession is defined, but never called. I
> assume this means people who are generating Perl code are quietly
> accumulating temporary session files...
>
> 4) Again in Common.pm, ToSQL is wrong. Instead of assuming that all
> database drivers use single quotes to delimit strings, it should use the
> DBI's quote function, which does this is a portable way.
>
> 5) The functions related to session variable could be a lot more efficient
> by factoring out the reading and writing to the file. Right now, each
call
> to GetSessionVar or SetSessionVar causes either a reread or a rewrite of
the
> underlying session file. This is wasteful.
>
>
|
|
|
|
|
